Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace in-place lists with tuples (2) #53685

Merged
merged 1 commit into from Jul 29, 2021
Merged

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 29, 2021

Proposed change

Continuation of #53684

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Dev automation moved this from Needs review to Reviewer approved Jul 29, 2021
cgtobi
cgtobi approved these changes Jul 29, 2021
Copy link
Contributor

@cgtobi cgtobi left a comment

Looks good for Netatmo

Copy link
Contributor

@jjlawren jjlawren left a comment

Plex looks good.

Copy link
Member

@janiversen janiversen left a comment

Modbus LGTM

bieniu
bieniu approved these changes Jul 29, 2021
Copy link
Member

@bieniu bieniu left a comment

Looks good for DuneHD.

bachya
bachya approved these changes Jul 29, 2021
Copy link
Contributor

@bachya bachya left a comment

AirVisual looks good!

@MartinHjelmare MartinHjelmare merged commit 0815eed into home-assistant:dev Jul 29, 2021
30 of 31 checks passed
Dev automation moved this from Reviewer approved to Done Jul 29, 2021
@cdce8p cdce8p deleted the cs_tuple-2 branch Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.