Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): add C# superblock #50646

Merged
merged 5 commits into from Jun 14, 2023

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Jun 9, 2023

This adds C# challenges as upcoming - nothing should be shown on production. This is just a starting point - there's a lot of things that need improvements here and there's a lot of work to do still - I want to save it for another PR.

Checklist:

Closes #XXXXX

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Jun 9, 2023
@codesee-maps
Copy link
Contributor

codesee-maps bot commented Jun 9, 2023

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@moT01 moT01 marked this pull request as ready for review June 12, 2023 04:33
@moT01 moT01 requested a review from a team as a code owner June 12, 2023 04:33
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moT01 I don't want to block this on account of the various weird things this PR surfaced, but they seem worth discussing. Please just resolve the conversations whenever you want, though.

client/i18n/locales/english/intro.json Outdated Show resolved Hide resolved
client/i18n/locales/english/intro.json Outdated Show resolved Hide resolved
client/i18n/locales/english/translations.json Show resolved Hide resolved
client/src/resources/cert-and-project-map.ts Show resolved Hide resolved
moT01 and others added 2 commits June 12, 2023 07:16
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 12, 2023
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Nice work, Tom 🚀

@Sembauke Sembauke merged commit 5e04985 into freeCodeCamp:main Jun 14, 2023
18 checks passed
@moT01 moT01 deleted the feat/add-csharp-superblock branch June 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants