Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: builduser update function #50642

Merged
merged 17 commits into from Jul 4, 2023
Merged

feat: builduser update function #50642

merged 17 commits into from Jul 4, 2023

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Jun 9, 2023

  • feat: build user update function
  • feat: build user update function

Checklist:

Closes #XXXXX

@github-actions github-actions bot added platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels Jun 9, 2023
@codesee-maps
Copy link
Contributor

codesee-maps bot commented Jun 9, 2023 •
edited

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Nirajn2311 Nirajn2311 mentioned this pull request Jun 10, 2023
Closed
4 tasks
@Sembauke Sembauke changed the title feat/builduser update function feat: builduser update function Jun 12, 2023
@github-actions github-actions bot removed the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Jun 12, 2023
ojeytonwilliams
ojeytonwilliams requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers guys.

I think we can work around the TS issues like so:

api/src/utils/get-challenges.ts Outdated Show resolved Hide resolved
api/src/utils/get-challenges.ts Outdated Show resolved Hide resolved
api/src/utils/get-challenges.ts Outdated Show resolved Hide resolved
Sembauke and others added 2 commits June 13, 2023 08:36
@Sembauke @ojeytonwilliams
Apply suggestions from Oliver
cfe3732 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@Nirajn2311
fix: type errors
bc58721
ojeytonwilliams
ojeytonwilliams approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sembauke Sembauke marked this pull request as ready for review June 13, 2023 08:51
@Sembauke Sembauke requested a review from a team as a code owner June 13, 2023 08:51
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 14, 2023
@raisedadead raisedadead added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jun 27, 2023
Sembauke and others added 2 commits June 29, 2023 09:36
@Sembauke @ShaunSHamilton
Apply suggestions from code review
b599ba9 
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
@Sembauke
fix: update function name
78cc7f0
@Nirajn2311 @ShaunSHamilton
fix: uncomment needsModeration update block
64352ce 
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
@Nirajn2311 Nirajn2311 removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Jul 2, 2023
@Nirajn2311 Nirajn2311 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 2, 2023
@Botkubot Botkubot mentioned this pull request Jul 4, 2023
Closed
ShaunSHamilton
ShaunSHamilton approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTM 👍

@ShaunSHamilton ShaunSHamilton merged commit e32f0c8 into freeCodeCamp:main Jul 4, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@Nirajn2311 Nirajn2311 Nirajn2311 left review comments

@naomi-lgbt naomi-lgbt naomi-lgbt left review comments

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

Assignees
No one assigned
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sembauke @ojeytonwilliams @Nirajn2311 @ShaunSHamilton @naomi-lgbt @raisedadead