feat(api): add :email unsubscribe/:email to the deprecated #50497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sboonny
added
the
status: waiting review
github-actions
bot
added
the
platform: api
|
👀 Review this PR in a CodeSee Review Map View the CodeSee Map of this changeLegend
|
ojeytonwilliams
requested changes
May 24, 2023
Sboonny
removed
the
status: waiting review
Sboonny
added
the
status: waiting review
ojeytonwilliams
previously requested changes
May 25, 2023
There was a problem hiding this comment.
These endpoints do not respond with JSON. They redirect the browser to the client with a query param that includes the flash message.
There's some discussion here: #50426 but I think we should talk about it again in today's meeting.
|
I am adding block label, until the issue is triaged. |
Sboonny
added
status: blocked
|
@Sboonny since we've confirmed the "clone the old api wherever possible" plan, we should use the redirects here. If you like, I'd be happy to create a quick PR/push a commitw |
4 tasks
|
Once #50525 is in, we can update this to use |
ojeytonwilliams
force-pushed
the
feat/add-two-email-deprecated-endpoint
branch
from
944d3b2
to
745c8fb
Compare
Sembauke
removed
the
status: blocked
Sembauke
approved these changes
Jun 15, 2023
moT01
added
the
status: waiting review
moT01
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.These endpoints are depercated in the old api too, so I have added them.