feat(curriculum): forum leaderboard project

[JoyShaheb]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

[codesee-maps]

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Legend

[jdwilkin4]

Left a couple of small comments 👍

Overall, I think this is a good start.
I think the thing to remember is that this project will be the last project campers do before the final certification project.

Some of your explanations can be shortened because campers will have already worked with those concepts in earlier projects and won't need as much explanation on how to do it. 👍

[bbsmooth]

Just a few accessibility-related issues.

• Is the empty column between Topics and Replies going to be used? If not then we should remove it.
• It is acceptable for tables to have horizontal scroll if the page gets too narrow to show all the data nicely. I would add a min width to the table (preferably in rem) to keep it from getting too compressed.
• I would also add a max-width to the table (preferably in rem) to keep the three smaller columns on the right from getting too far away from the Topics column.
• Actually, you could do away with a max-width if you didn't set a width on the the table to begin with and just let it fill the space as needed. If you are worried about a topic getting too wide then you could se a max-width just on the first td.

[lasjorg]

We should check the response and try/catch the fetch.

We should build the string before adding it to the DOM, not concatenate it directly to the DOM. Another option would be to use map and join instead of forEach.

[zairahira]

I have reviewed steps 1 to 30 and left some feedback.
The challenges are simple and easy to understand. The tests also passed for each challenge. 🚀

[naomi-lgbt]

Hey Joy,

This is off to a good start. I've left some comments on the first 10 JavaScript steps, to help demonstrate some of the style and functional approaches we try to use.

[scissorsneedfoodtoo]

I wasn't able to review too many steps in detail, but hopefully these comments, along with the reviews Naomi, Jessica, and Zaira left, provide some guidance.

[scissorsneedfoodtoo]

This file was removed in a recent change. You can drop this change in favor of the suggestion in curriculum/challenges/_meta/learn-intermediate-fetch-promises-and-async-await-by-building-an-fcc-forum-leaderboard/meta.json.

You should see that this file has been removed when you rebase with upstream/main and solve the merge conflicts.

[JoyShaheb]

@scissorsneedfoodtoo need some here here buddy

[scissorsneedfoodtoo]

My bad. We still need this file, but the format has changed and there are some other properties.

Here's an example of the current format of the file: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/_meta/learn-basic-javascript-by-building-a-role-playing-game/meta.json

[zairahira]

I have reviewed the next 20 steps(31 to 50) and left some comments to simplify the instructions!👍

[zairahira]

Reviewed steps 51-60.

[zairahira]

Reviewed steps 61-70.

There is a typo categorieList from steps 65 onwards. I have fixed this to categoryList and updated the tests/ seed code between 65-70. Is there a quick way to do it @JoyShaheb as this variable name is being used throughout the project?

[zairahira]

Some more comments for steps 71-80.

[zairahira]

With this comment, I have reviewed the entire project. 🚀 I have left some suggestions as well.

[zairahira]

@JoyShaheb the following steps are the HTML and CSS steps related to setting up the layout and styling and can be removed:

• Steps #1 to #18(included)
• Step #61
• Steps #87 to #99(included)
• Step #112
• Step #114